Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use purity inference #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

smores56
Copy link
Owner

Purity inference has been merged, so once the return fix is ready in this PR, we can validate this PR and then merge.

@smores56 smores56 mentioned this pull request Nov 12, 2024
@lukewilliamboswell
Copy link
Collaborator

@smores56

I think we should land this. It would keep our basic-cli build.roc script simple, just need a new Weaver release. Otherwise we have to do the breaking change, jump-start thing.

@lukewilliamboswell
Copy link
Collaborator

Never mind... I found other issues, and so simplified the build script to not use Weaver or any arg parsing as a dependency.

@smores56
Copy link
Owner Author

Glad to hear it's not breaking anymore. I'd like to, if possible, merge allowing pure statements that contain early returns since it cleans up code with multiple trys in Validate.roc. If that can get merged in the next 12 hours or so, then I'll fix that up and then merge this. It's not blocking, though, so I'll merge this tomorrow morning otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants