-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TCP Timestamp option #939
Conversation
Looks good at a quick glance. |
Hi, I would appreciate if someone could review this PR (or approve if it indeed looks good) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like you to also add RFC 7323 to the src/socket/tcp.rs
file header, since it is also now necessary to understand the semantics. Once you're done please squash the commits.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
==========================================
- Coverage 79.97% 79.21% -0.77%
==========================================
Files 81 81
Lines 27831 26820 -1011
==========================================
- Hits 22259 21245 -1014
- Misses 5572 5575 +3 ☔ View full report in Codecov by Sentry. |
4d4824e
to
ccd8c7f
Compare
Ok, the codecov window is refusing to update. |
Yeah so codecov is having some infra issues. That's ok. I talked to their CTO, they'll fix it eventually but not yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot better but I'd still much prefer there to be a struct for the timestamp itself with inherent method(s) to manipulate it to the current situation with extensive tuple access. I can take a closer look and propose a specific structure if you'd like.
Agreed, that made for cleaner access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was unclear, see inline comments.
I'm on vacation for a week. Later! |
@whitequark gentle ping, regarding the fixes I've made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the work you put into this and the fixes.
This is currently not relating to the RTT estimation, just for supporting remotes who do support it.
The generator isn't a lambda to avoid a generic.
Tests include a logic test of an established session and tests which make sure this option is only enabled if the both sides support it.