Use core instead of std for net types.
#937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To fix MSRV should this be gated behind an |
|
IMO we can just increase the MSRV, unless someone has some objection. |
|
Have brought the msrv up. If it's okay, I will fix the clippy lints in another PR to not pollute this one with unrelated changes. |
|
Bumping the MSRV brings with it the changes to Clippy's lints. In my opinion, it's fine to have the linting changes in this PR. If they're done in a separate commit, it's still easy to follow. |
|
Ready for review. |
|
there's more places where MSRV should be updated, like the readme. please grep for "1.65" and update them all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful for using
.into()with these types on no_std platforms.