fix(pcap): IEEE802.15.4 without FCS pcap link type #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since smoltcp does not generate the FCS, the pcap link type should be set to IEEE802.15.4 without FCS.
thvdveld
force-pushed
the
pcap-ieee802154-without-fcs
branch
from
4d49e17
to
5a94a32
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
=======================================
Coverage 79.74% 79.74%
=======================================
Files 78 78
Lines 28137 28137
=======================================
Hits 22439 22439
Misses 5698 5698 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since smoltcp does not generate the FCS, the pcap link type should be set to IEEE802.15.4 without FCS.