Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config constants public #855

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Make config constants public #855

merged 1 commit into from
Nov 13, 2023

Conversation

nilfit
Copy link
Contributor

@nilfit nilfit commented Nov 13, 2023

This allows dependent crates to use the constants directly instead of duplicating the system of features and conversion into constants.

This allows dependent crates to use the constants directly instead of
duplicating the system of features and conversion into constants.
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #855 (88fa2c2) into main (9b791ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files          78       78           
  Lines       27890    27890           
=======================================
  Hits        22206    22206           
  Misses       5684     5684           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Dirbaio Dirbaio added this pull request to the merge queue Nov 13, 2023
Merged via the queue into smoltcp-rs:main with commit b57e2f9 Nov 13, 2023
14 checks passed
@nilfit nilfit deleted the pub-config branch November 13, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants