Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TUNSETIFF on MIPS, PPC and SPARC #839

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Support TUNSETIFF on MIPS, PPC and SPARC #839

merged 1 commit into from
Sep 20, 2023

Conversation

blechschmidt
Copy link
Contributor

@blechschmidt blechschmidt commented Sep 6, 2023

This commit adds support for the TUNSETIFF constant on MIPS, PPC and
SPARC. The TUNSETIFF constant defined in the Linux kernel headers uses
architecture-specific macros. For this commit, the architecture-specific
definitions of the constant in the Golang source code were consulted.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #839 (47c9a59) into main (28a5dd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #839   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files          78       78           
  Lines       27809    27809           
=======================================
  Hits        22131    22131           
  Misses       5678     5678           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@crawford
Copy link
Contributor

crawford commented Sep 6, 2023

Can you please distill the linked conversation and include it in your commit message? It's helpful to keep all of the relevant information in git, as opposed to forcing people to open their browser when trying to understand the commit history.

This commit adds support for the TUNSETIFF constant on MIPS, PPC and
SPARC. The TUNSETIFF constant defined in the Linux kernel headers uses
architecture-specific macros. For this commit, the architecture-specific
definitions of the constant in the Golang source code were consulted.
@blechschmidt
Copy link
Contributor Author

The commit message and the code comment now include more information.

@blechschmidt blechschmidt changed the title Support TUNSETIFF on MIPS and PPC64 Support TUNSETIFF on MIPS, PPC and SPARC Sep 9, 2023
@thvdveld
Copy link
Contributor

Thank you!

@thvdveld thvdveld added this pull request to the merge queue Sep 20, 2023
Merged via the queue into smoltcp-rs:main with commit e6dd013 Sep 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants