Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IpPacket rewrite #802

Merged
merged 1 commit into from
Jun 28, 2023
Merged

IpPacket rewrite #802

merged 1 commit into from
Jun 28, 2023

Conversation

thvdveld
Copy link
Contributor

I rewrote IpPacket such that we can add hop-by-hop headers, fragment headers and routing headers to the representation. I discussed in #800 why I needed those changes.

The downside is that the IpPacket struct is now 264 bytes, and thus clippy complains about this.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #802 (2152c80) into main (aa5d887) will decrease coverage by 0.13%.
The diff coverage is 46.87%.

❗ Current head 2152c80 differs from pull request most recent head 618d7e3. Consider uploading reports for the commit 618d7e3 to get more accurate results

@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   79.65%   79.53%   -0.13%     
==========================================
  Files          71       72       +1     
  Lines       27786    27711      -75     
==========================================
- Hits        22134    22041      -93     
- Misses       5652     5670      +18     
Impacted Files Coverage Δ
src/iface/interface/mod.rs 49.67% <2.63%> (+0.17%) ⬆️
src/iface/ip_packet.rs 50.00% <50.00%> (ø)
src/iface/interface/sixlowpan.rs 74.93% <61.90%> (ø)
src/iface/interface/ipv4.rs 68.50% <93.75%> (+0.53%) ⬆️
src/iface/interface/ipv6.rs 91.38% <100.00%> (+0.12%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thvdveld
Copy link
Contributor Author

I think that the size variant should not be an issue.

@thvdveld
Copy link
Contributor Author

@Dirbaio I added the feature flags as discussed on Matrix.

@thvdveld thvdveld marked this pull request as ready for review June 28, 2023 12:11
@Dirbaio
Copy link
Member

Dirbaio commented Jun 28, 2023

🚀 thank you!

@Dirbaio Dirbaio added this pull request to the merge queue Jun 28, 2023
Merged via the queue into smoltcp-rs:main with commit 5fb8679 Jun 28, 2023
@thvdveld thvdveld deleted the ip-packet-rewrite branch June 28, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants