use socklen_t instead of u32 for bind() parameter #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix compilation on Android 32b, where socklen_t is i32
|
bors r+ ??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation on Android 32b, where
socklen_tisi32. This changes nothing on almost all other platforms as theirsocklen_tis alreadyu32.Solarish and VxWorks are the two other exceptions, they both use
c_uintas theirsocklen_t. For x86_64-sun-solaris and sparcv9-sun-solaris I was able to confirmc_uintis in fact au32, so it worked before, and still works now.For vxworks, I did not found a toolchain I could install with rustup to confirm whether it worked before, but anyway it should work now.