Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build when with no socket features #416

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Fix build when with no socket features #416

merged 1 commit into from
Feb 1, 2021

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Feb 1, 2021

Building like this

cargo test --no-default-features --features std,proto-ipv4

fails with this

error[E0392]: parameter `'a` is never used
--> src/socket/mod.rs:84:17
|
84 | pub enum Socket<'a> {
|                 ^^ unused parameter

This used to work before, was broken by #410 . Rather than adding back a dummy enum variant, this fixes the issue by making the entire socket module optional, only built if at least one socket feature is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants