feat: Expose other kqueue filters #83
Conversation
src/os/kqueue.rs
Outdated
| /// No matter what `PollMode` is specified, this filter will always be | ||
| /// oneshot-only. | ||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)] | ||
| pub struct Signal(c_int); |
There was a problem hiding this comment.
it would make more sense to just make the single wrapped field pub and omit the construct/destruct methods.
src/os/kqueue.rs
Outdated
| /// Identifier for the timer. | ||
| id: usize, | ||
|
|
||
| /// The timeout to wait for. | ||
| timeout: Duration, |
src/os/kqueue.rs
Outdated
|
|
||
| impl Timer { | ||
| /// Create a new timer. | ||
| pub fn new(id: usize, timeout: Duration) -> Self { |
There was a problem hiding this comment.
if the fields of this struct would be marked pub, these methods could be omitted.
|
suggestion: also uhh it's suboptimal that you put 2 independent changes into the last commit (one which moved the file, and a fixup), that makes it harder to review, would be nice if you could avoid that in the future... looks otherwise pretty ok now. thx |
|
Sorry about that, and thanks for the review! Regarding the |
|
oh btw the reason I suggested |
Good point. I've updated it so the fields are |
* feat: Expose other kqueue filters * Fix netbsd/openbsd compilation * Build MSRV for FreeBsd/OpenBsd in CI * Only run MSRV BSD builds on Linux * Change API a little + fix netbsd timer * Add inlines + move PollerSealed * rustfmt * Make filter fields public * Fix examples
This PR uses extension traits to expose other
kqueuefilters, like signals and child processes.Supercedes #72
Closes #68