Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace log with tracing #119

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Replace log with tracing #119

merged 4 commits into from
Jun 21, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Jun 11, 2023

Supersedes #65

@notgull notgull mentioned this pull request Jun 11, 2023
Closed
@zeenix
Copy link
Member

zeenix commented Jun 11, 2023

What's the diff with #65?

@notgull
Copy link
Member Author

notgull commented Jun 11, 2023

There has been quite a few changes since #65 (most notably #88) and rebasing it would be more difficult than just rewriting it. In essence, no difference.

@zeenix
Copy link
Member

zeenix commented Jun 11, 2023

Fair enough but you could just force push to the same branch and avoid the noise, keep all information/discussion in the same place and avoid this discussion as well. 😊

fogti
fogti reviewed Jun 12, 2023
View reviewed changes
src/epoll.rs Outdated Show resolved Hide resolved
@notgull
Copy link
Member Author

notgull commented Jun 14, 2023

Fair enough but you could just force push to the same branch and avoid the noise, keep all information/discussion in the same place and avoid this discussion as well. blush

I already deleted the branch so I can't re-open #65, unfortunately.

@taiki-e taiki-e mentioned this pull request Jun 14, 2023
Merged
@notgull notgull mentioned this pull request Jun 14, 2023
Merged
fogti
fogti reviewed Jun 14, 2023
View reviewed changes
src/epoll.rs Outdated
Comment on lines 69 to 71
epoll_fd= ?poller.epoll_fd.as_raw_fd(),
event_fd= ?poller.event_fd.as_raw_fd(),
timer_fd= ?poller.timer_fd,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhh why does it still use ? and not %?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the raw FD is just a number there shouldn't be a difference, although I can adjust it if it's an issue.

@zeenix
Copy link
Member

zeenix commented Jun 14, 2023

I already deleted the branch so I can't re-open #65, unfortunately.

Oh, no I wasn't suggesting that. That was for future reference. Sorry for not making it clear.

taiki-e
taiki-e reviewed Jun 18, 2023
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/epoll.rs Outdated Show resolved Hide resolved
src/epoll.rs Outdated Show resolved Hide resolved
src/epoll.rs Outdated Show resolved Hide resolved
src/epoll.rs Outdated Show resolved Hide resolved
src/epoll.rs Outdated Show resolved Hide resolved
src/port.rs Outdated Show resolved Hide resolved
src/port.rs Outdated Show resolved Hide resolved
src/port.rs Outdated Show resolved Hide resolved
src/port.rs Outdated Show resolved Hide resolved
src/port.rs Outdated Show resolved Hide resolved
@notgull notgull merged commit 7a1fd31 into master Jun 21, 2023
@notgull notgull deleted the notgull/tracing2 branch June 21, 2023 03:28
@notgull notgull mentioned this pull request Aug 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fogti fogti fogti left review comments

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notgull @zeenix @fogti @taiki-e