feat: Add scheduling options for listener lists. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
requested changes
Dec 31, 2024
src/lib.rs
Outdated
| @@ -127,6 +127,16 @@ use sync::WithMut; | |||
| use notify::NotificationPrivate; | |||
| pub use notify::{IntoNotification, Notification}; | |||
|
|
|||
| /// Queue schedule of a listener. | |||
| #[derive(Clone, Copy, Debug, PartialEq)] | |||
| pub enum Sched { | |||
There was a problem hiding this comment.
This should be #[non_exhaustive].
| @@ -127,6 +127,16 @@ use sync::WithMut; | |||
| use notify::NotificationPrivate; | |||
| pub use notify::{IntoNotification, Notification}; | |||
|
|
|||
| /// Queue schedule of a listener. | |||
| #[derive(Clone, Copy, Debug, PartialEq)] | |||
There was a problem hiding this comment.
I would prefer a name more descriptive than Sched. Maybe QueueStrategy?
src/intrusive.rs
Outdated
Comment on lines
247
to
259
| match mem::replace(replacing, Some(entry.into())) { | ||
| None => *replacing = Some(entry.into()), | ||
| Some(t) if self.sched == Sched::Lifo => unsafe { | ||
| t.as_ref().prev.set(Some(entry.into())) | ||
| }, | ||
| Some(t) if self.sched == Sched::Fifo => unsafe { | ||
| t.as_ref().next.set(Some(entry.into())) | ||
| }, | ||
| Some(_) => unimplemented!("unimplemented scheduling type"), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Would prefer it if this block became:
match (mem::replace(replacing, Some(entry.into())), self.sched) {
/* ... */
}
Two strategies are available: - FIFO: The original round-robin queuing; listeners are inserted at the back. - LIFO: The new most-recent queuing; listeners are inserted at the front. LIFO queuing is beneficial for cache-efficiency with workloads that are tolerant of starvation. The same listener is repeatedly drawn from the list until the load dictates additional listeners be drawn from the list. These listeners expand outward as a "hot set" for optimal reuse of resources rather than continuously drawing from the coldest resources in a FIFO schedule. Signed-off-by: Jason Volk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two schedulers are available:
LIFO queuing is beneficial for cache-efficiency with workloads that are tolerant of starvation. The same listener is repeatedly drawn from the list until the load dictates additional listeners be drawn from the list. These listeners expand outward as a "hot set" for optimal reuse of resources rather than continuously drawing from the coldest resources in a FIFO schedule.