Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port from once-cell to async-lock #26

Merged
merged 2 commits into from
Nov 27, 2022
Merged

Port from once-cell to async-lock #26

merged 2 commits into from
Nov 27, 2022

Conversation

notgull
Copy link
Member

@notgull notgull commented Nov 26, 2022

See here. We need to remove all usage of once_cell here and replace it with async-lock. This PR largely replaces usage of once_cell::Lazy with async_lock::OnceCell.

taiki-e
taiki-e approved these changes Nov 27, 2022
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit a44d0b4 into smol-rs:master Nov 27, 2022
@notgull notgull deleted the async-lock branch November 27, 2022 04:12
@taiki-e taiki-e mentioned this pull request Nov 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notgull @taiki-e