Port to event-listener v5.0 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2024
|
@notgull some unanswered questions here before we could merge this. |
|
Oh and it needs a rebase. |
cc smol-rs/event-listener#105 Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
zeenix
approved these changes
Feb 7, 2024
|
All good. Only thing is that if async-channels's Sender/Receiver are turning |
|
Sure, if you're fine with the API break. |
Sure, assuming there is a good chance the performance benefits that async-channel is expected to gain from this change, will also apply here. |
Signed-off-by: John Nunley <[email protected]>
zeenix
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Make
SendandRecv!Unpinto allow for future optimizations (API break).cc smol-rs/event-listener#105