Ladders: Fix crash #8015
Ladders: Fix crash #8015
Conversation
server/ladders-remote.ts
Outdated
| const p1id = p1 ? p1.id : toID(p1name); | ||
| const p2id = p2 ? p2.id : toID(p2name); |
There was a problem hiding this comment.
Why not just always toID(p1name)?
Co-authored-by: Guangcong Luo <[email protected]>
| /** | ||
| * Calculates Elo based on a match result | ||
| */ |
There was a problem hiding this comment.
The original PR had a much more useful comment which seems to have been ripped out for no reason
| const p2Act = (p1score > 0.9 || p1score < 0 ? `losing` : (p1score < 0.1 ? `winning` : `tying`)); | ||
| let p2Reasons = `${p2NewElo - p2OldElo} for ${p2Act}`; | ||
| if (!p2Reasons.startsWith('-')) p2Reasons = '+' + p2Reasons; | ||
| room.addRaw(Utils.html`${p2name}'s rating: ${p2OldElo} → <strong>${p2NewElo}</strong><br />(${p2Reasons})`); |
There was a problem hiding this comment.
You forgot to remove the old rating messages when you added these new messages in, so now messages are appearing twice.
| /** | ||
| * Calculates Elo based on a match result | ||
| */ | ||
| private calculateElo(previousUserElo: number, score: number, foeElo: number): number { |
There was a problem hiding this comment.
This formula is wrong; it's generating different results from ntbb-ladder.php:
Kennedy ⌐◼_◼'s rating: 1000 → 1064
(+64 for winning)
eaubot's rating: 1157 → 1128
(-29 for losing)
Kennedy ⌐◼_◼'s rating: 1000 → 1057
(+57 for winning)
eaubot's rating: 1157 → 1121
(-36 for losing)
(gen8challengecup1v1 battle)
There was a problem hiding this comment.
Your duplicate result bug at least allowed us to catch this...
* Ladders: Fix crash * OK * Update ladders-remote.ts * Update server/ladders-remote.ts Co-authored-by: Guangcong Luo <[email protected]> * Update server/ladders-remote.ts Co-authored-by: Guangcong Luo <[email protected]>
Caused by smogon#8015 incorrectly copy/pasting only parts of smogon#7960. I also cleaned up the ladder fast-update code while I was working on this.
A user namechanging before the battle ended in any way would break this.