Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve base power modifiers #447

Merged
merged 5 commits into from
Aug 20, 2021
Merged

Improve base power modifiers #447

merged 5 commits into from
Aug 20, 2021

Conversation

DaWoblefet
Copy link
Member

@DaWoblefet DaWoblefet commented May 11, 2021

Implements most of the base power issues in #443; I didn't want to do everything at once so it'd be easier to code review. Notably, I did not implement the Speed-based modifier chaining yet; I'll need to think about that some more and want to tackle it in a separate PR once I take care of the low-hanging fruit.

Moves with custom BP:

  • Steel Roller and Poltergeist now fail earlier before even entering BP calculation
  • Payback, Acrobatics, Weather Ball now no longer use hardcoded damage values
  • Pursuit was changed to be a move with variable base power
  • Smelling Salts and Triple Kick were added as moves with variable base power
  • Gyro Ball's formula was corrected

Base Power modifiers:

  • BP modifiers are now grouped by effect type (move, ability, etc.) then by modifier
  • Zamazenta with Rusted Shield doesn't increase Knock Off
  • Expanding Force, Rising Voltage, and Misty Explosion changed to base power modifiers
  • Technician's mechanics were corrected (the past theory about temporary chaining is very wrong)
  • Aura mechanics were corrected (they only apply once)
  • Punk Rock (offensive) changed to a base power modifier

Misc:

  • Terrain Pulse and Nature Power now list their typing and base power in desc

@DaWoblefet
Copy link
Member Author

Well the linter is complaining but idk what I did wrong here; I changed max-len in eslint from 100 -> 120 to match Showdown's server line length limit but apparently it didn't like that :(

@DaWoblefet DaWoblefet requested a review from KrisXV May 11, 2021 02:52
@DaWoblefet
Copy link
Member Author

Another bump for review @KrisXV - I wanted to get the entirety of #443 done over the summer. I'll merge myself if you're still busy, since these are objective bugfixes.

@KrisXV KrisXV merged commit 5e8e7f3 into smogon:master Aug 20, 2021
@KrisXV
Copy link
Member

KrisXV commented Aug 20, 2021

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants