Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add click-to-copy feature #441

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Add click-to-copy feature #441

merged 1 commit into from
Jan 8, 2023

Conversation

DimK19
Copy link
Contributor

@DimK19 DimK19 commented Apr 9, 2021

Made a very small addition using the Clipboard API. I ran npm test locally, apparently the two failing tests are unrelated to it. Hope it works properly!

@KrisXV
Copy link
Member

KrisXV commented Apr 27, 2021

Hey! Sorry for the delay; could you provide a screenshot of how this looks?

@DimK19
Copy link
Contributor Author

DimK19 commented Apr 29, 2021

Hello! Here's how it looks currently (my mouse pointer is not showing on the screenshot, but is on the main result sentence and changes to "hand-pointer")
image

Since opening the request, I've thought of making a tooltip pop up after clicking, as a confirmation, but it is not ready yet. Also, I noticed the failing tests have been fixed in subsequent pr's, so if you could tell me how to fix them I'll do it here too. Thanks.

@DimK19 DimK19 closed this Apr 30, 2021
@DimK19 DimK19 reopened this Apr 30, 2021
@DimK19
Copy link
Contributor Author

DimK19 commented Apr 30, 2021

I had trouble syncing my fork with the latest build, so I just hard reset and made a new commit. Now it is passing all the tests locally.
image
The pop-up tooltip disappears after 2 seconds.

@DimK19 DimK19 closed this by deleting the head repository Oct 4, 2022
@DimK19
Copy link
Contributor Author

DimK19 commented Dec 11, 2022

@KrisXV Hello, I am re-opening this because the feature would be quite useful. It is still requested by this issue: #348, under "Approved Features". Details with screenshots in the messages above.
Please let me know if any changes must be made. Thanks.

@DimK19 DimK19 reopened this Dec 11, 2022
@AustinXII
Copy link
Member

@DimK19 sorry for the late replies, I will look at this today and get back to you. It looks pretty good at a click glance though!

@monsanto
Copy link
Member

monsanto commented Jan 8, 2023

Seems like useful functionality, hopefully Austin will review it but if it doesn't happen I will.

@AustinXII AustinXII merged commit 583eddb into smogon:master Jan 8, 2023
@AustinXII
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants