Add generation for CFN handler permissions #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Oct 14, 2021
...dformation/src/main/java/software/amazon/smithy/aws/cloudformation/schema/model/Handler.java
Outdated
Show resolved
Hide resolved
...ware/amazon/smithy/aws/cloudformation/schema/fromsmithy/mappers/HandlerPermissionMapper.java
Outdated
Show resolved
Hide resolved
...ware/amazon/smithy/aws/cloudformation/schema/fromsmithy/mappers/HandlerPermissionMapper.java
Show resolved
Hide resolved
This commit introduces automatic generation for handler permissions based on the lifecycle operation used and permissions listed in the @aws.iam#requiredActions trait on that operation.
kstich
force-pushed
the
support_cfn_handlers
branch
from
5e42f93
to
034c731
Compare
mtdowling
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces automatic generation for handler permissions
based on the lifecycle operation used and permissions listed in the
@aws.iam#requiredActionstrait on that operation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.