Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert blob default values to Base64 #2474

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

jbelkins
Copy link
Contributor

Background

Convert blob default values to Base64 in awsJson1_0 & restJson1 protocol tests.

Testing

  • Generated to Swift SDK protocol tests.

Links

  • Links to additional context, if necessary
  • Issue #, if applicable (see here for a list of keywords to use for linking issues)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested a review from a team as a code owner November 21, 2024 17:49
Copy link

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#2474" --type feature --description "fix: Convert blob default values to Base64"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

@hpmellema hpmellema merged commit b25ac1c into smithy-lang:main Nov 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants