Added Docgen files to the main smithy repo. #2468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasmewad
force-pushed
the
docgen-integ
branch
from
22126d4
to
0101c16
Compare
…to work with Docgen java version.
yasmewad
force-pushed
the
docgen-integ
branch
from
0101c16
to
7803f00
Compare
haydenbaker
reviewed
Nov 20, 2024
Comment on lines
+50
to
+56
| if (project.name == "smithy-docgen-core" || project.name == "smithy-docgen-test") { | ||
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| targetCompatibility = JavaVersion.VERSION_17 | ||
| } else { | ||
| sourceCompatibility = JavaVersion.VERSION_1_8 | ||
| targetCompatibility = JavaVersion.VERSION_1_8 | ||
| } |
There was a problem hiding this comment.
Can you use toolchain instead?
|
You'll need to update the CI script to correctly build the repository now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What do these changes do?
These changes pull in the docgen repositories to be built as part of the main smithy repository.
Why are they important?
These changes help us centralize and publish smithy docgen. It also enables publishing for the docgen plugin.
Testing
Gradle build.
I also ran it with the README and instructions. Updated the readme where necessary.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.