More httpChecksum trait validation for responses #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpmellema
requested changes
Aug 14, 2024
| if (trait.getResponseAlgorithms().isEmpty()) { | ||
| events.add(error(operation, trait, "The `httpChecksum` trait must model the" | ||
| + " `responseAlgorithms` property to support response checksum behavior.")); | ||
| return events; |
There was a problem hiding this comment.
If we return here will customers miss errors for the next check? I think we could just add the events here with no return.
There was a problem hiding this comment.
hmm yeah, not sure why we are returning above for !trait.getRequestValidationModeMember().isPresent() case. also bit odd that the header conflicts for output shape and errors are split like this.
gosar
force-pushed
the
response-checksum-validator
branch
from
fd014c2
to
43c12ac
Compare
gosar
force-pushed
the
response-checksum-validator
branch
from
43c12ac
to
19c128d
Compare
hpmellema
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This adds validation to httpChecksum trait for response checksumming behavior. When configuring the trait for response checksumming, the list of checksum algorithms to consider must be provided. Else, the client behavior would have no algorithms to validate.
The docs for response validation say
So, this list should not be empty.
Testing
Added tests for this case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.