Replace outdated RFC references #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 7231 was obsoleted by RFC 9110 in 2022. This updates references to the old RFC to the equivalent sections in the new one. Note that the actual content of the referenced sections are semantically unchanged.
RFC 7230 has been obsoleted by RFC 9110 and RFC 9112. This replaces references to the old RFC with references to the relevant sections of the new RFC.
JordonPhillips
commented
May 23, 2024
| @@ -106,9 +106,8 @@ method | |||
| The ``method`` property defines the HTTP method of the operation (e.g., "GET", | |||
| "PUT", "POST", "DELETE", "PATCH", etc). Smithy will use this value literally | |||
| and will perform no validation on the method. The ``method`` value SHOULD | |||
| match the ``operation`` production rule of :rfc:`7230#appendix-B`. This | |||
There was a problem hiding this comment.
This production doesn't seem to exist, even on RFC7230, so I replaced it with a reference to what I think it was talking about.
hpmellema
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP RFCs have received some facelifts recently. The vast majority of the HTTP spec is now collected in RFC 9110 with version-specific information broken out into their own RFCs (HTTP 1.1 is in RFC 9112 for example).
This PR updates any references we have to RFCs obsoleted by RFC 9110 and RFC 9112 to those newer RFCs. The semantic content of these sections has not changed, only the presentation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.