Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support internal trait when building synthetic enum trait #2106

Merged

Conversation

JordonPhillips
Copy link
Contributor

When converting the normal enum trait to an enum shape, we convert the "internal" tag into the @internal trait. This updates the opposite direction conversion used to generate the synthetic enum trait to add the "internal" tag if the member had the @internal trait if it isn't already in the list of tags.

I also added a few other test cases for the member -> enum trait definition test that didn't seem to be covered, at least from the perspective of an enum shape that wasn't itself generated by converting a string shape.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This updates the conversion of enum members to enum trait definitions
to add the "internal" tag if the trait is present.
@JordonPhillips JordonPhillips merged commit ad8aac3 into smithy-lang:main Jan 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants