Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split input and output shapes for rest-xml tests #2063

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Dec 6, 2023

This PR splits InputOutput shapes into separate request and response shapes for rest-xml protocol tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srchase srchase requested a review from a team as a code owner December 6, 2023 23:13
Copy link
Contributor

@JordonPhillips JordonPhillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and add the input and output traits while you're at it. Heck even just inlining them might be easier

@srchase srchase merged commit 0a4b0fd into main Dec 8, 2023
11 checks passed
@srchase srchase deleted the rest-xml-tests branch December 8, 2023 15:58
rchache pushed a commit to rchache/smithy that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants