Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unwrap docs #2040

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update unwrap docs #2040

merged 1 commit into from
Nov 14, 2023

Conversation

msosnicki
Copy link
Contributor

Description of changes:
The documentation of unwrap currently mentions only ERROR, but in the implementation, isBroken with following implementation is used:

    public boolean isBroken() {
        for (ValidationEvent event : events) {
            if (event.getSeverity() == Severity.ERROR || event.getSeverity() == Severity.DANGER) {
                return true;
            }
        }
        return false;
    }

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@msosnicki msosnicki requested a review from a team as a code owner November 14, 2023 15:29
@sugmanue
Copy link
Contributor

@msosnicki thank you for you contribution.

@sugmanue sugmanue merged commit 10964ee into smithy-lang:main Nov 14, 2023
10 checks passed
rchache pushed a commit to rchache/smithy that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants