Add warnings for ignored HTTP member bindings #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvschneid
approved these changes
Sep 1, 2023
hpmellema
reviewed
Sep 1, 2023
...ava/software/amazon/smithy/model/validation/validators/HttpBindingTraitIgnoredValidator.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/model/validation/validators/HttpBindingTraitIgnoredValidator.java
Show resolved
Hide resolved
kstich
force-pushed
the
http_validation
branch
from
a3108b9
to
982f3a8
Compare
mtdowling
requested changes
Sep 1, 2023
...sources/software/amazon/smithy/model/errorfiles/validators/http-binding-trait-ignored.errors
Outdated
Show resolved
Hide resolved
kstich
force-pushed
the
http_validation
branch
2 times, most recently
from
108a0ca
to
63bb8a8
Compare
mtdowling
approved these changes
Sep 1, 2023
This commit adds a new validator that emits a warning when a member has an HTTP member binding trait applied and its container is referenced through a relationship where it would be ignored. Spec clarification of this behavior has been added.
kstich
force-pushed
the
http_validation
branch
from
63bb8a8
to
e4d16e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new validator that emits a warning when a member has an HTTP member binding trait applied and its container is referenced through a relationship where it would be ignored.
Spec clarification of this behavior has been added.
Issue #, if available:
Resolves #1379
Resolves #1386
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.