Add ability to alias referenced symbols #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
add-symbol-reference-alias
branch
from
b787f19
to
0548b39
Compare
This commit updates SymbolReference to now have an "alias" to allow a symbol to be referenced with an alias. By default, the alias is assigned the same value as the name of the referenced symbol. However, some code generators may wish to alias referenced symbols to ensure that they do not conflict with generated symbols (for example, you might want to alias "SmithyStructure" as "$SmithyStructure" because no generated type would ever start with '$'). Code generators that do not support or need aliases are free to ignore this added property.
mtdowling
force-pushed
the
add-symbol-reference-alias
branch
from
0548b39
to
23c155c
Compare
kstich
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates SymbolReference to now have an "alias" to allow a
symbol to be referenced with an alias. By default, the alias is assigned
the same value as the name of the referenced symbol. However, some code
generators may wish to alias referenced symbols to ensure that they do
not conflict with generated symbols (for example, you might want to
alias "SmithyStructure" as "$SmithyStructure" because no generated type
would ever start with '$').
Code generators that do not support or need aliases are free to ignore
this added property.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.