Remove unconditional adding of util-base64 node and browser modules #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
util-base64-node-browser-remove-unconditional-add
branch
from
2c1bcdc to
735d24a
Compare
kuhe
approved these changes
Nov 11, 2022
trivikr
deleted the
util-base64-node-browser-remove-unconditional-add
branch
milesziemer
pushed a commit
to milesziemer/smithy-typescript
that referenced
this pull request
Dec 14, 2022
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The util additions of dependencies util-base64-node and util-base64-browser were manually replaced to that of util-base64 in aws/aws-sdk-js-v3#4140
However, they were re-added by codegen while updating clients endpoints from 2022-11-04 in aws/aws-sdk-js-v3@7471107
Description of changes:
Remove unconditional adding of util-base64 node and browser modules
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.