Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support List<String> in function parameters list #516

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Support List<String> in function parameters list #516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80fd244
Support List<String> in function paramters list
trivikr Dec 2, 2021
a64dde1
fix checkstyle errors
trivikr Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...escript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,14 @@ static List<String> getFunctionParametersList(Map<String, Object> paramsMap) {
functionParametersList.add(String.format("%s: '%s'", key, value));
} else if (value instanceof Boolean) {
functionParametersList.add(String.format("%s: %s", key, value));
} else if (value instanceof List) {
if (!((List) value).isEmpty() && !(((List) value).get(0) instanceof String)) {
throw new CodegenException("Plugin function parameters not supported for type List<"
+ ((List) value).get(0).getClass() + ">");
}
functionParametersList.add(String.format("%s: [%s]",
key, ((List<String>) value).stream()
.collect(Collectors.joining("\", \"", "\"", "\""))));
} else {
// Future support for param type should be added in else if.
throw new CodegenException("Plugin function parameters not supported for type "
Expand Down