Revert "fix: stop adding serde middleware repeatedly (#259)" #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c57cca3. client instance, the command still consumes the configuration of the previous client interface. This issue is resolved by allowing adding middleware to the stack without throwing error. So smithy-lang#259 is no longer needed.
trivikr
approved these changes
Jan 28, 2021
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
…" (smithy-lang#267) This reverts commit c57cca3. If a command instance is used by a different client instance, the command still consumes the configuration of the previous client interface. This issue is resolved by allowing adding middleware to the stack without throwing error. So smithy-lang#259 is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c57cca3.
Solves: aws/aws-sdk-js-v3#1935
Related to: aws/aws-sdk-js-v3#1964
If a command instance is used by a different client instance, the
command still consumes the configuration of the previous client
interface. This issue is resolved by allowing adding middleware
to the stack without throwing error. So #259 is no longer needed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.