Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: binding the methods to the context #1466

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Conversation

massi-ang
Copy link
Contributor

Issue #, if available:
Fixes #1465
Description of changes:
Added context binding

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@massi-ang massi-ang requested a review from a team as a code owner December 5, 2024 18:11
@massi-ang
Copy link
Contributor Author

massi-ang commented Dec 6, 2024

Apparently this is an issue only with Electron, or at least the setup I am using where, the node-http-handler is being used. I do not observe the same behaviour in a pure browser application.
Assuming you need the timing variable, the correct fix is to use arrow functions (bind did not work as this after compilation is not what I expected). I pushed the new change.

@kuhe kuhe merged commit a257792 into smithy-lang:main Dec 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting TypeError: Illegal invocation when calling any AWS SDK method in a browser window in Electron
2 participants