fix(node-http-handler): skip sending body without waiting for a timeout on response, if "expect" request header with "100-continue" is provided #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut on response, if "expect" request header with "100-continue" is provided
…ut on response, if "expect" request header with "100-continue" is provided
kuhe
approved these changes
Nov 25, 2024
|
I don't have an ETA, but it may be a few weeks before this is released due to Thanksgiving holiday and re:Invent. |
|
This was published in v3.3.2 of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently, S3 in AWS-SDK uses "expect: 100-continue" header.
In case of errors, for example "403 Forbidden", the request fails only on timeout. This happens because while sendRequestBody is waiting for "continue" event, a "response" event is fired and "continue" is not fired at all.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.