chore: add default accepts header for rpcv2Cbor #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Oct 8, 2024
| @@ -266,7 +266,8 @@ protected void writeSharedRequestHeaders(GenerationContext context) { | |||
| writer.openBlock("const SHARED_HEADERS: __HeaderBag = {", "};", () -> { | |||
| writer.write("'content-type': $S,", getDocumentContentType()); | |||
| writer.write(""" | |||
| "smithy-protocol": "rpc-v2-cbor" | |||
| "smithy-protocol": "rpc-v2-cbor", | |||
| "accept": "application/cbor", | |||
There was a problem hiding this comment.
this is overridden on line 298 if there is event stream output
kstich
approved these changes
Oct 8, 2024
siddsriv
approved these changes
Oct 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a default
accept: application/cborrequest header for the rpcv2cbor protocol.