Protocol codegen fixes via protocol tests #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the following fixes, each in their own commit for ease of review:
This commit removes the MetadataBearer type for non-error output
shapes in the model. This makes them not require having a metadata
property when being reused as non-response shapes (batches, etc.)
Output shapes instead become MetadataBearers as part of compound
types in the Command and Client codegen.
This commit updates query collection serialization to properly create
Set types. It also fixes an issue where query collections of non-string
simple types were not deserializing to their proper primitive type.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.