fix(node-http-handler): fix invalid usage of parsed url #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defman
force-pushed
the
urlToHttpOptions
branch
2 times, most recently
from
5810491 to
4ae8460
Compare
Defman
force-pushed
the
urlToHttpOptions
branch
from
4ae8460 to
3647425
Compare
|
@kuhe is this something you could have a look at? |
kuhe
approved these changes
Sep 20, 2024
kuhe
force-pushed
the
urlToHttpOptions
branch
from
60dc1d5 to
bf40cbb
Compare
hpmellema
approved these changes
Sep 20, 2024
Closed
4 tasks
|
Any chance of getting it bumped in https://github.com/aws/aws-sdk-js-v3 ? |
|
yes, but it will happen at a later date. A lockfile update or other type of fresh install would bring in the fix. |
|
Yea, I feel a bit stupid right now... had been trying to get my fork to work with npm overrides all day... however after it got merged I should of course just run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
Description of changes:
Nodejs
URLis not fully compatible withhttp.RequestOptionssee nodejs/node#39738By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.