feat(node-http-handler): defer socket event listener attachment #1384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/aws-sdk-js-v3#6423
This PR defers the registration of
socket
event listeners on individual requests outgoing fromnode:http(s)
requests.Attaching events creates a small performance overhead (0-2ms) and I believe they are unnecessary for requests that resolve in under 3 seconds for timeouts of greater than 6 seconds.
Here is a comparison of the use-case of a request before and after this PR:
Before PR
After PR