-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(smithy-client): add handler cache #1383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/client
branch
2 times, most recently
from
August 30, 2024 15:42
46a9e3b
to
10ed6c1
Compare
Closed
1 task
kuhe
commented
Sep 3, 2024
kuhe
force-pushed
the
feat/client
branch
4 times, most recently
from
September 3, 2024 20:05
42b892d
to
659e4f7
Compare
milesziemer
reviewed
Sep 5, 2024
update: the main issue was how to detect when to invalidate the cache. Rather than solving that problem, which may have made things worse for the problem the cache is solving, I've made the use of it configurable and opt-in. |
milesziemer
approved these changes
Sep 9, 2024
siddsriv
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/aws-sdk-js-v3#6423
This adds a cache for the handler functions resolved from calls to
when options is undefined. This occurs in the request path and can take 1-2ms, but is redundant for any client/command pair in most cases.
Despite being cached, the handler functions has a reference to the client config, so any changes there will still be visible to the middleware within the resolved handler.
Modifying a client's middlewareStack invalidates the cache.The cache is opt-in and also unique per client, so users retain control that way.