add default endpoint to protocol test stub #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Jul 16, 2024
|
|
||
| const clientParams = { | ||
| region: "us-west-2", | ||
| credentials: { accessKeyId: "key", secretAccessKey: "secret" } | ||
| } | ||
| endpoint: "https://localhost/", |
There was a problem hiding this comment.
This is the only change. The rest is formatting to match TypeScript code standards present in the repository.
milesziemer
approved these changes
Jul 16, 2024
trivikr
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to creating a set of default plugins in #1321, an endpoint must be provided for non-Endpoints-RuleSet service models' clients.
Providing a default endpoint in protocol tests is required for the non-Endpoints-RuleSet case, and also non-breaking otherwise.