fix(node-http-handler): add logger option and clear timeout on errors #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/node-http-handler-timeout
branch
from
cbb34fd to
93679bf
Compare
kuhe
force-pushed
the
fix/node-http-handler-timeout
branch
from
93679bf to
ccb7592
Compare
siddsriv
approved these changes
Jun 17, 2024
haydenbaker
approved these changes
Jun 17, 2024
syall
approved these changes
Jun 18, 2024
| `socket usage at capacity=${socketsInUse} and ${requestsEnqueued} additional requests are enqueued.`, | ||
| "See https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/node-configuring-maxsockets.html", | ||
| "or increase socketAcquisitionWarningTimeout=(millis) in the NodeHttpHandler config." | ||
| logger?.warn?.( |
There was a problem hiding this comment.
nit: do we need the ? on warn?
There was a problem hiding this comment.
we don't based on the type itself, but users sometimes don't provide the right logger implementation
There was a problem hiding this comment.
it's somewhat common and not just hypothetical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1305