-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add logging for CredentialsProviderError #1290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
May 23, 2024
@@ -19,7 +21,7 @@ export const fromEnv = | |||
return config as T; | |||
} catch (e) { | |||
throw new CredentialsProviderError( | |||
e.message || `Cannot load config from environment variables with getter: ${envVarSelector}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we were previously logging the Function.toString()
value, which is quite unreadable...
motivated by issue reported in #1288 |
1 task
trivikr
approved these changes
May 24, 2024
syall
approved these changes
May 29, 2024
kuhe
commented
May 29, 2024
syall
approved these changes
May 29, 2024
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
May 30, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jun 5, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jun 7, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jun 18, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jun 19, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jun 24, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jul 8, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jul 9, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
Jul 15, 2024
* chore: add logging for CredentialsProviderError * use options object * var name clarity * test fixes * formatting * set internal tag on getSelectorName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable access to the log of instantiated
CredentialsProviderError
s.In the AWS SDK with its many credential sources (default chain), the sequence through which you may end up with a certain provider in the chain is unclear, and seeing the history of thrown
CredentialProviderError
s helps with both maintainer and user debugging.Example log:
Example 2, debugging credential chain: