Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prettier to 3.2.5 #1265

Merged
merged 5 commits into from
May 9, 2024
Merged

Bump prettier to 3.2.5 #1265

merged 5 commits into from
May 9, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented May 8, 2024

Issue #, if available:

Description of changes:

Bump prettier to 3.2.5


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but missing empty changesets file

Changes noticed:

  • Trailing commas are more consistent in generic types
  • Indentation is more consistent (2 spaces, and for ternaries)
  • Multi-line constructors for multiple params
  • New lines per arrow function definition

prettier.config.js Show resolved Hide resolved
@trivikr trivikr marked this pull request as ready for review May 9, 2024 15:13
@trivikr trivikr requested review from a team as code owners May 9, 2024 15:13
@trivikr trivikr requested a review from AndrewFossAWS May 9, 2024 15:13
@trivikr trivikr merged commit 74a4554 into main May 9, 2024
10 checks passed
@trivikr trivikr deleted the bump-prettier branch May 9, 2024 15:42
kuhe pushed a commit to kuhe/smithy-typescript that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants