Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type transforms account for no-args operation methods #1262

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: type transforms account for no-args operation methods #1262

merged 1 commit into from
May 8, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 8, 2024 •
edited
Loading

aws/aws-sdk-js-v3#6065

fix type transforms for Clients to handle the case where a method has an additional no-args signature.

  • no-args signature was a feature added after the addition of the AssertiveClient/UncheckedClient type transforms.

@kuhe kuhe requested review from a team as code owners May 8, 2024 19:38
@kuhe kuhe requested a review from haydenbaker May 8, 2024 19:38
@kuhe kuhe force-pushed the fix/type-transforms branch from 9626ea7 to 08b6228 Compare May 8, 2024 19:46
@kuhe kuhe merged commit 7a7c84d into smithy-lang:main May 8, 2024
10 checks passed
@kuhe kuhe deleted the fix/type-transforms branch May 8, 2024 20:12
kuhe added a commit to kuhe/smithy-typescript that referenced this pull request May 28, 2024
@kuhe
fix: type transforms account for no-args operation methods (smithy-la…
81d537b 
…ng#1262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syall syall syall approved these changes

@haydenbaker haydenbaker Awaiting requested review from haydenbaker haydenbaker was automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @syall