Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty the contents of the dependencyVersions.properties file when creating it #1213

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Mar 18, 2024

I found that my dependencyVersions.properties and sdkVersions.properties files had thousands of lines in them, which is redundant.

The build process creates these files by reading the package json versions of AWS code and of Smithy packages.

These file numbers are used in our dependency enums when initializing an enum value with no particular version number:

public enum TypeScriptDependency implements Dependency {

    SMITHY_CORE("dependencies", "@smithy/core", false),

During releases to maven, the then-current versions within the workspace are stamped into the maven artifact. Since the action appends the version to the end of the file, presumably the latest versions will be written in the HashMap, regardless of what may exist already in the file.

There was a report that 0.19.0 of the smithy-aws-typescript-codegen package had duplicate entries in the sdkVersions.properties file.

@kuhe kuhe merged commit 2ae3d07 into smithy-lang:main Mar 18, 2024
7 checks passed
@kuhe kuhe deleted the chore/gradle branch March 18, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants