fix(util-base64): allow arrays to stand in for Uint8Array (runtime only) #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reesscot
approved these changes
Mar 12, 2024
syall
approved these changes
Mar 12, 2024
5 tasks
siddsriv
approved these changes
Mar 12, 2024
gosar
pushed a commit
to gosar/smithy-typescript
that referenced
this pull request
May 28, 2024
gosar
pushed a commit
to gosar/smithy-typescript
that referenced
this pull request
May 28, 2024
gosar
pushed a commit
to gosar/smithy-typescript
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some application code using arrays
[]instead ofUint8Array, ignoring types.https://github.com/aws-amplify/amplify-ui/blob/bd05991f9bf0f666694c90d6445b63dcc8c795f3/packages/react-liveness/src/components/FaceLivenessDetector/service/utils/streamProvider.ts#L174-L198
We requested the client code to patch the behavior, but we can modify this to be consistent with prior runtime behavior as well.
ArrayLike values are acceptable but not preferred (for compactness) in lieu of Uint8Array because in the browser implementation, data is read from index entries of the input object.