Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): use SerdeFunctions type as serde plugin input, but call serde functions as type SerdeContext #1183

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Mar 7, 2024

This fixes type compatibility of the latest version of serdePlugin with older code generation that isn't on the classBuilder syntax.

@kuhe kuhe requested review from a team as code owners March 7, 2024 21:04
@kuhe kuhe requested a review from JordonPhillips March 7, 2024 21:04
@kuhe kuhe force-pushed the fix/types branch 3 times, most recently from e2904bf to d38f9ba Compare March 7, 2024 21:15
@kuhe kuhe merged commit 32e3f6f into smithy-lang:main Mar 7, 2024
6 of 7 checks passed
@kuhe kuhe deleted the fix/types branch March 7, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants