feat(credential-provider-imds): support ECS and EKS credential uris #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the use of EKS Pod Identities in EKS
armsnyder
changed the title
kuhe
approved these changes
Jan 17, 2024
|
this should no longer be necessary, since the AWS SDK has been updated to look for credentials from the new sources. Use v3.515.0 or higher of the JSv3 AWS SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1143
I added more allowed hostnames for the
AWS_CONTAINER_CREDENTIALS_FULL_URIenvironment variable. These allowed hostnames match the ones allowed by the official Go SDK. See: https://github.com/aws/aws-sdk-go-v2/blob/a7db10670faedd542dc92cec6d0c602e5315a3a9/config/resolve_credentials.go#L33-L52Note that I have not tried deploying an app to EKS with this build of
@smithy/credential-provider-imds, so I do not know for certain if this is the only issue that is preventing the use of EKS Pod Identities on EKS.