Add util-endpoints package #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
util-endpoints
branch
from
473cf2e to
f2ccbeb
Compare
kuhe
reviewed
Oct 17, 2023
| customEndpointFunctions: null | EndpointFunctions; | ||
| } = { | ||
| customEndpointFunctions: null, | ||
| }; |
There was a problem hiding this comment.
- todo from our discussion: allow multiple namespaces to be registered in customEndpointFunctions
srchase
force-pushed
the
util-endpoints
branch
3 times, most recently
from
0f84f4f to
a1b205a
Compare
srchase
force-pushed
the
util-endpoints
branch
from
a1b205a to
12770e1
Compare
kuhe
approved these changes
Oct 20, 2023
syall
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates most of the @aws-sdk/util-endpoints package to this repository.
The AWS specific functions used for resolving endpoints will remain in @aws-sdk/util-endpoints. Those functions will be injected into AWS clients via the
endpointFunctionscontainer that has been added to this package.AWS clients will inject AWS specific functions with the following by consuming the
@aws-sdk/util-endpointspackage.The injected endpoint functions can then be used by this package to resolve endpoints along side the built-in endpoint resolution functions.
Follow-on PRs will update the smithy-typescript code generator to use this new dependency once it has been published to NPM.
If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.