fix(node-http-handler): omit setting cache setting on request init wh…

…en using default value (#1411) * Fixes #1407
smithy-lang · Sep 20, 2024 · 0d5ab1d · 0d5ab1d
1 parent 71b163b
commit 0d5ab1d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/good-cheetahs-wait.md b/.changeset/good-cheetahs-wait.md
@@ -0,0 +1,5 @@
+---
+"@smithy/fetch-http-handler": patch
+---
+
+Omit setting cache setting on request init when using default value
diff --git a/packages/fetch-http-handler/src/fetch-http-handler.ts b/packages/fetch-http-handler/src/fetch-http-handler.ts
@@ -112,8 +112,12 @@ export class FetchHttpHandler implements HttpHandler<FetchHttpHandlerConfig> {
       headers: new Headers(request.headers),
       method: method,
       credentials,
-      cache: this.config!.cache ?? "default",
     };
+    // cache property is not supported in workerd runtime
+    // TODO: can we feature detect support for cache and not set this property when not supported?
+    if (this.config?.cache) {
+      requestOptions.cache = this.config.cache;
+    }
 
     if (body) {
       requestOptions.duplex = "half";