enable hyper1 as default http client #3939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Dec 6, 2024
Comment on lines
+60
to
+62
| // takes precedence over legacy connector if enabled | ||
| #[cfg(feature = "default-http-connector")] | ||
| let _default = aws_smithy_http_client::default_client(); |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Dec 9, 2024
…ttp-client directly
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
default-http-connectorfeature toaws-smithy-runtimethat enables hyper 1.x with rustls+aws-lc as the default HTTP client plugin.connector-hyper-014-xfeature is enabled the new feature takes precedence such that the default HTTP client plugin favors hyper 1 if both features are enabled.default-http-connectorfeature instead of hyper 0.14rustlsfeature flag so it has instead been updated to enable thedefault-http-connectorfeature.aws-configto default to hyper1 for the default credentials chain.aws-config,rustlsandclient-hyper, that seem to be used entirely to enable theaws-smithy-runtimefeaturestls-rustlsandconnector-hyper-0-14-xfeatures (both are required for the default HTTP client plugin to work prior to this PR). I think the intent behind these features was "the user is not providing an HTTP client explicitly so we need a default one to be available". I've added a new feature toaws-configfor this,default-http-connectorand updated the existing features to be synonyms. We don't userustlsorhyper 0.14.xdirectly inaws-configso I think this is a more clearly defined flag and conveys it's intent better.legacy-test-utilfeature flag toaws-smithy-runtime. The rationale for this is that thetest-utilfeature provides testing utilities for other things fromaws-smithy-runtimebut it also brings in the (now) legacy hyper 0.14 HTTP testing facilities. I've lefttest-utilto mean what it does today and be backwards compatibile (for now anyway) and in future we can ship a (breaking) change to disable the legacy test utils by default (and by extension stop compiling the legacy hyper ecosystem in all of our tests)examples/pokemon-service-commondue to codegen no longer generating clients with theaws-smithy-runtime/tls-rustlsfeature enabled by default (they are using theHyperClientBuilder::build_https()method directly but relying on feature unification to enable the method)Questions
aws-config/default-http-connectorcould be more generic likedefault-providersor something. Today we use it to mean "we need a default HTTP client" but you can imagine a future where we need other default runtime components to exist and be configured. Perhaps that is what we want from this flag?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.