Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws-lambda as a feature to generated server SDK #3648

Merged
merged 13 commits into from
Jun 20, 2024

Conversation

drganjoo
Copy link
Contributor

Motivation and Context

The generated SDK conditionally re-exports routing::LambdaHandler under the feature flag aws-lambda, but the Cargo.toml does not define such a feature.

Description

Closes: #3643

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@drganjoo drganjoo marked this pull request as ready for review May 21, 2024 12:38
@drganjoo drganjoo requested review from a team as code owners May 21, 2024 12:38
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

CHANGELOG.next.toml Outdated Show resolved Hide resolved
CHANGELOG.next.toml Outdated Show resolved Hide resolved
examples/pokemon-service-lambda/src/main.rs Show resolved Hide resolved
drganjoo and others added 2 commits May 23, 2024 12:03
Co-authored-by: david-perez <[email protected]>
Co-authored-by: david-perez <[email protected]>
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@drganjoo drganjoo added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit 99e1e20 Jun 20, 2024
44 checks passed
@drganjoo drganjoo deleted the fahadzub/gen-feature-aws-lambda branch June 20, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing aws-lambda feature flag definition in Cargo.toml
3 participants